Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#11432 closed defect (bug) (fixed)

Dashboard Spam link uses wrong action

Reported by: caesarsgrunt's profile caesarsgrunt Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.9
Component: Trash Keywords: has-patch
Focuses: Cc:

Description

The Spam link on the dashboard still uses action=deletecomment&dt=spam, rather than the new action=spamcomment.

Although this does spam the comment, it means that the previous status isn't stored and so it isn't correctly unspammed.

Attachments (2)

11432.1.diff (1007 bytes) - added by caesarsgrunt 15 years ago.
Simple fix (changes action in spam link)
11432.2.diff (2.7 KB) - added by caesarsgrunt 15 years ago.
Better patch (also combines deletecomment into the same function as all the other delete actions)

Download all attachments as: .zip

Change History (5)

@caesarsgrunt
15 years ago

Simple fix (changes action in spam link)

@caesarsgrunt
15 years ago

Better patch (also combines deletecomment into the same function as all the other delete actions)

#1 @caesarsgrunt
15 years ago

  • Keywords has-patch added; needs-patch removed

The first patch just fixes the bug by changing the spam link to use the spamcomment action.

The second patch does the same, but also moves the deletecomment action into the same function as trashcomment, untrashcomment, spamcomment, and unspamcomment, since almost all code for it was duplicated. I should have merged this when I merged the others before....

#2 @nacin
15 years ago

Cross-referencing #11426. Incidentally, I have also merged the deletecomment action there. I also merged approvecomment and unapprovecomment -- and realistically, all six could be merged.

#3 @azaozz
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [12401]

Note: See TracTickets for help on using tickets.