Opened 15 years ago
Closed 12 years ago
#11436 closed enhancement (wontfix)
Adding wmode transparent to flash videos
Reported by: | aldolat | Owned by: | Viper007Bond |
---|---|---|---|
Milestone: | Priority: | high | |
Severity: | normal | Version: | 2.9 |
Component: | Embeds | Keywords: | has-patch |
Focuses: | Cc: |
Description
WP 2.9 should add this line
<param name='wmode' value='transparent' />
among other params inside the object tag when inserting a video from Youtube and others sites.
Also, it should add
<embed ... wmode="transparent" ... >
in the the embed tag.
While these parameters are already present in the press-this.php file, the standard writing panel doesn't include them.
If these declarations are not present, the video overlaps another element in the page that should be on top of others elements (such as a dropdown menu that would be hidden by a flash video).
Attachments (3)
Change History (25)
#2
@
15 years ago
Keep in mind that wmode="transparent" does use more reources on the client's system than the opaque variant.
#3
@
15 years ago
- Keywords reporter-feedback added
Please provide steps on how to reproduce that it's not inserted right now.
#4
@
15 years ago
Step 1
When you want to publish a video from Youtube (for example), you paste the URL to the video. So paste this into the writing panel:
http://www.youtube.com/watch?v=tgbNymZ7vqY
Step 2
Publish the post.
Step 3
Go to your blog. The video appears above any other element, such as a dropdown menu. If your wordpress theme has a dropdown menu, it should appear above the video, not below. Here a screenshot:
http://www.mediafire.com/imageview.php?quickkey=zy0yzq0njjy
#6
@
15 years ago
Could reproduce. Is this only for oembed or are there other areas that should be considered to care by a patch.
#7
@
15 years ago
- Type changed from defect (bug) to enhancement
there are plentiful other areas. basically, anything that potentially adds an object tag is subject to this.
an additional improvement, while we're at it, could be to automatically use SWFObject.
#8
@
15 years ago
- Component changed from Media to Embeds
- Owner set to Viper007Bond
- Status changed from new to assigned
#9
@
15 years ago
I'm strongly tempted to wontfix this. I'm not sure we should try to mess with oembed responses and should leave it to a plugin for when the oembed provider doesn't include it.
#10
@
15 years ago
Yes, opaque is better than transparent.
I'm on the fence on this one though. oEmbed exists so we don't have to mess around with the embed HTML. YouTube also doesn't provide this parameter in their embed HTML anywhere, even on the standard video page where you copy/paste it. They used to have it, but removed it as it is generally considered a harmful parameter unless you absolutely need it. This is because the wmode
parameter makes the player inaccessible to keyboard users (they can't tab into it and it's controls).
On the other hand, this can be a really annoying issue. I'm making the new version of my Video Quicktags plugin have an option to add the wmode
parameter for example
I think I'm going to recommend wontfix
with the reasoning being that YouTube knows what they are doing and it's easy for a plugin to fix this using the embed_oembed_html
filter.
#12
@
15 years ago
- Resolution set to wontfix
- Status changed from assigned to closed
aldolat: A plugin can easily handle this by using a filter that currently exists in WordPress and hooking into and 'filtering' the HTML.
#14
in reply to:
↑ 11
@
15 years ago
Replying to aldolat:
I agree. But how about adding this option into WordPress?
Too many options is a bad thing. You get lost in them all. WordPress aims to only provide a UI for the really important things and leave the rest to filters which plugins can use to change things.
#16
@
14 years ago
Does it make sense to add wmode
only if Admin Bar is displayed? Attaching the patch.
#18
@
14 years ago
- Keywords has-patch added; needs-patch removed
- Resolution wontfix deleted
- Status changed from closed to reopened
Reopening for consideration, as per the comments above.
+1. It's a true annoyance when it's not present. We should also add it when code returned by oembed doesn't add it already.