get_body_class() does unnecessary work

[filosofo]

get_blog_class() calls setup_postdata() unnecessarily, when there's an API in WP_Query for exactly this purpose.

Patch fixes.

[hakre]

Tested against current head. Works. Then I reviewed the code and AND post_status != 'private' looks to me like this fixes some other bug. I have created an additional patch w/o that segment. If applied, a new ticket might be created based on the finding by filosofo.

[hakre]

Patch without SQL modification

[hakre]

My patch is wrong, global $wpdb is still needed and should not be removed.

[Denis-de-Bernardy]

I like the first patch, though I'd suggest using get_queried_object() directly.

[Denis-de-Bernardy]

I also get a fatal error when I apply it.

[filosofo]

use Denis's approach to the private page issue

[filosofo]

I incorporated Denis's suggestion for handling private pages, fixed the fatal error, but left out the unrelated stuff that Denis has in 11439.diff.

unnecessary_global_tampering.11439.diff should be the best patch now. Agreed?

[Denis-de-Bernardy]

agreed. marking as tested, too. played around with static pages, attachment pages, and so on. nothing crept up.

I'll open a separate ticket related to the rest.

[Denis-de-Bernardy]

see #11811

[ryan]

(In [12877]) Avoid call to setup_postdata(). Use get_queried_object_id(). Props filosofo. fixes #11439