Comment moderation AYS should provide feedback on comment's current status
|Reported by:||nacin||Owned by:||nacin|
If multiple users receive comment moderation e-mails (say, if the admin e-mail goes to multiple people, or if the pluggable wp_notify_moderator() function is replaced), then one moderator should know what the other moderator may have done.
For example, if user A takes an action on a comment, then user B clicks a comment action link from e-mail, the AYS will provide no feedback that the comment is no longer unapproved. If both admins approve the comment, then wp_notify_postauthor will be triggered twice. Or, the admins could have done conflicting actions -- one moved it to trash, and the next approved it -- and the admin taking the second action would not know from the AYS screen that the comment was already in the trash.
Fixing this this will require some new checks in wp-admin/comment.php. Tickets #11432 and #11426 would make some changes to this file, and this ticket is designed to expand in 3.0 on those improvements. Will patch once #11426 is addressed.
- If a comment is no longer unapproved, the form should clearly reflect what its current status is.
- In some cases, the new status might need to be prevented or an extra step would be required, if only behind the scenes. (For example, a trashed comment would need to first be untrashed before being approved. This doesn't happen now, which means meta is not cleaned up, etc.)
- If the form is attempting to change the comment status to the comment's current status, it should return you to edit-comments.php with a message.
- If the comment ID doesn't exist, instead of wp_die, it should return you to edit-comments.php with a message saying that the ID doesn't exist or that the comment was deleted.
Those are all of the cases I have for now.