WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11447 closed defect (bug) (fixed)

"Crunching" overlaps image name

Reported by: caesarsgrunt Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9
Component: Upload Keywords: has-patch tested
Focuses: Cc:

Description

See attached screenshot.

Attachments (4)

Screen shot 2009-12-11 at 18.18.45.png (10.4 KB) - added by caesarsgrunt 4 years ago.
bad, bad, bad…
11447-WordPress_1261867383763.png (1.6 KB) - added by hakre 4 years ago.
11447.patch (378 bytes) - added by hakre 4 years ago.
11447.diff (332 bytes) - added by Denis-de-Bernardy 4 years ago.
refresh against trunk

Download all attachments as: .zip

Change History (14)

caesarsgrunt4 years ago

bad, bad, bad...

comment:1 hakre4 years ago

But how to solve? Adding a grey border to the term? We must keep in mind that there is a status-bar in the background as well that is filling up while crunching....

comment:2 caesarsgrunt4 years ago

The status bar has already filled when crunching begins, so we could just add a solid background the colour of the status bar to the crunching notice, I guess. Not a terribly elegant solution, but...

This would also be helped if image names weren't centred during uploading. They aren't centred any other time anyway, so there's no reason for them to be centred in the first place.

comment:3 hakre4 years ago

I was looking into this. The text of the image is actually displayed above the Crunching... text, so no luck with background colors. For debugging purposes I made the crunching text red and attached a screenshot.

Related URL: wp-admin/media-upload.php?post_id=3&type=image&tab=type

Related: #11446

hakre4 years ago

comment:4 hakre4 years ago

Patch did fix for me. Remember to enable style_debug:

// use .dev.css styles instead of the packed ones.
define('STYLE_DEBUG', true);

// use .dev.js scripts instead of the packed ones.
define('SCRIPT_DEBUG', true);
define('CONCATENATE_SCRIPTS', false);

comment:5 hakre4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

comment:6 hakre4 years ago

  • Milestone changed from Unassigned to 3.0

comment:7 Denis-de-Bernardy4 years ago

  • Keywords tested added; needs-testing removed

Denis-de-Bernardy4 years ago

refresh against trunk

comment:9 azaozz4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12654]) Don't let "Crunching" overlap image name while uploading, props hakre, fixes #11447

comment:10 azaozz4 years ago

Needed to take out the "align center" as with some filename lengths it hides the right part while having some space on the left.

Note: See TracTickets for help on using tickets.