"Select Files" and "Cancel Upload" have different border colours

[caesarsgrunt]

Select Files looks like it's disabled or something. See attached screenshot.

[nacin]

Related: #8545

[hakre]

Is this a duplicate or a different case?

[caesarsgrunt]

A different case. This patch is about the border colour of the two buttons not matching each other (very obvious, looks like the Select button is disabled), the other is about the background colour around the button not matching the rest of the page (much less obvious).

[hakre]

File upload in thickbox - flash uploader - current head

[hakre]

looks fixed to me but maybe caesarsgrunt is referring to some other file.

[hakre]

While looking onto my screenshot I can see the background color is not matching the rest of the page. Confirm for that screenshot and current trunk. Bordercolor looks fixed.

Button is referenced as parameter and is a PNG file. It is located here:
/wp-includes/images/upload.png

It has a background color of #F9F9F9, the page has a background color of #FFFFFF. So this is wrong. The background color of the image must be changed from #F9F9F9 to #FFFFFF.

The image was uploaded by ryan in [9421]. Ryan should have source-files for that image which should make it more easy to provide corrected versions.

[hakre]

Additional Info: upload.png was actually attached by filosofo:
​http://core.trac.wordpress.org/attachment/ticket/6979/upload.png

So he might be the man here.

[nacin]

Let's handle this together with #8545. Correct the border color, and correct the gray background (it's also used on a gray background IIRC, so we may need to create a new image or add white background images to the sprite).

Ultimately, much of this may change with 3.1 and the planned media/upload overhaul. Setting to 3.1 for now.

[nacin]

Looks good to me:

​http://cl.ly/280d0K0v3C430u2a1e0c

​http://cl.ly/0h0f08261E3c1s2b3W1V

Going to ask the UI group to keep this in mind when generating a new image for #8545.

[nacin]

Ah, this was fixed by #12420. In turn, that then flipped #8545 to make the bug about the Media Add New screen, rather than the media upload thickbox.