WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#11448 closed defect (bug) (duplicate)

"Select Files" and "Cancel Upload" have different border colours

Reported by: caesarsgrunt Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.9
Component: Upload Keywords: ui-feedback
Focuses: Cc:

Description

Select Files looks like it's disabled or something. See attached screenshot.

Attachments (2)

Screen shot 2009-12-12 at 11.41.45.png (9.4 KB) - added by caesarsgrunt 4 years ago.
11448-2009-12-26-1261846920305.png (13.2 KB) - added by hakre 4 years ago.
File upload in thickbox - flash uploader - current head

Download all attachments as: .zip

Change History (13)

comment:1 nacin4 years ago

Related: #8545

comment:2 hakre4 years ago

Is this a duplicate or a different case?

comment:3 caesarsgrunt4 years ago

A different case. This patch is about the border colour of the two buttons not matching each other (very obvious, looks like the Select button is disabled), the other is about the background colour around the button not matching the rest of the page (much less obvious).

hakre4 years ago

File upload in thickbox - flash uploader - current head

comment:4 hakre4 years ago

  • Keywords reporter-feedback added; needs-patch removed

looks fixed to me but maybe caesarsgrunt is referring to some other file.

comment:5 hakre4 years ago

  • Keywords dev-feedback added; reporter-feedback removed

While looking onto my screenshot I can see the background color is not matching the rest of the page. Confirm for that screenshot and current trunk. Bordercolor looks fixed.

Button is referenced as parameter and is a PNG file. It is located here:
/wp-includes/images/upload.png

It has a background color of #F9F9F9, the page has a background color of #FFFFFF. So this is wrong. The background color of the image must be changed from #F9F9F9 to #FFFFFF.

The image was uploaded by ryan in [9421]. Ryan should have source-files for that image which should make it more easy to provide corrected versions.

comment:6 hakre4 years ago

Additional Info: upload.png was actually attached by filosofo:
http://core.trac.wordpress.org/attachment/ticket/6979/upload.png

So he might be the man here.

comment:7 nacin4 years ago

  • Milestone changed from Unassigned to 3.1

Let's handle this together with #8545. Correct the border color, and correct the gray background (it's also used on a gray background IIRC, so we may need to create a new image or add white background images to the sprite).

Ultimately, much of this may change with 3.1 and the planned media/upload overhaul. Setting to 3.1 for now.

comment:8 nacin3 years ago

  • Milestone changed from Awaiting Triage to 3.1

comment:9 nacin3 years ago

  • Keywords ui-feedback added; dev-feedback removed

Looks good to me:

http://cl.ly/280d0K0v3C430u2a1e0c

http://cl.ly/0h0f08261E3c1s2b3W1V

Going to ask the UI group to keep this in mind when generating a new image for #8545.

comment:10 nacin3 years ago

  • Milestone 3.1 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

comment:11 nacin3 years ago

Ah, this was fixed by #12420. In turn, that then flipped #8545 to make the bug about the Media Add New screen, rather than the media upload thickbox.

Note: See TracTickets for help on using tickets.