Bulk "Delete Permanently" moves attachments to trash

[scribu]

On the Media editing screen, choosing "Delete Permanently" moves selected attachments to the trash, instead of deleting them.

[PeteMall]

I wasn't able to replicated this. Trash for Media was removed from 2.9 and the "Delete Permanently" action deletes the attachments on my local trunk install.

[nacin]

I can reproduce. Looking into it.

[nacin]

We need to add checks for EMPTY_TRASH_DAYS and MEDIA_TRASH.

[ryan]

Shouldn't that still check for !$force_delete rather than $force_delete?

[nacin]

Typo in patch.

[nacin]

Yep, already repatched.

[automattor]

(In [12415]) Delete instead of trash when bulk deleting media. Props nacin. fixes #11455

[ryan]

We might also want to check MEDIA_TRASH in wp_trash_post() if the type is attachment. This seems good enough for now though.

[nacin]

Also adds MEDIA_TRASH check to wp_trash_post.

[nacin]

Patch to add MEDIA_TRASH check to wp_trash_post.

Random thought -- we should add wp_trash_attachment() to 3.0.

[azaozz]

Replying to nacin:

Random thought -- we should add wp_trash_attachment() to 3.0.

Yes, don't really like how wp_trash_post() calls wp_delete_attachment() and wp_delete_attachment() calls back wp_trash_post() in the above patch...

[hakre]

Aren't this two tickets? The one is fixed and the additional stuff still opened?

[hakre]

nacin, I'll close the ticket for now because I hope that will catch your attention. Shouldn't we move the "unfixed"/new part into it's own ticket? (see my last comment)

[dd32]

I'll close the ticket for now because I hope that will catch your attention

Please dont close tickets in order to get someones attention..

[nacin]

Replying to hakre:

nacin, I'll close the ticket for now because I hope that will catch your attention. Shouldn't we move the "unfixed"/new part into it's own ticket? (see my last comment)

There isn't harm in keeping them as one ticket. There was one part we needed to commit late in 2.9. The rest is directly linked to this but didn't need to go into 2.9, so a core dev moved the milestone to 3.0.

I would consider spinning off the last patch here to a new ticket that also includes wp_trash_attachment(), but wp_trash_attachment() will be addressed after the resolutions of #11470 and #11394, and trash for media.

[nacin]

We never got to trash for media in 3.0.