WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#11463 closed defect (bug) (fixed)

Orphaned comment metadata in DB after comment is removed

Reported by: sirzooro's profile sirzooro Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.9
Component: Comments Keywords: has-patch
Focuses: Cc:

Description

wp_delete_comment() should delete all comment medadata associated with comment.

Attachments (2)

11463.diff​ (1.1 KB) - added by nacin 15 years ago.
11463.2.diff​ (1.9 KB) - added by nacin 15 years ago.
Second patch works a bit more like wp_delete_post. Adds deleted_comment action and deletes comment after meta is deleted (that way meta hooks can react).

Download all attachments as: .zip

Change History (8)

#1 @nacin
15 years ago

  • Keywords has-patch added; needs-patch removed

I was looking at this the other day but couldn't get around to a patch and never submitted a ticket.

@nacin
15 years ago

@nacin
15 years ago

Second patch works a bit more like wp_delete_post. Adds deleted_comment action and deletes comment after meta is deleted (that way meta hooks can react).

#2 @westi
15 years ago

Second patch looks reasonable.

#3 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12428]) Delete all comment meta when deleting a comment. Props nacin. fixes #11463

#4 @ryan
15 years ago

[12429] for 2.9.

#5 @ryan
15 years ago

(In [12431]) Delete all comment meta when deleting a comment. Props nacin. fixes #11463 for 2.9

#6 @ryan
15 years ago

I committed the wrong patch the first time around. Committed again with patch 2.

Note: See TracTickets for help on using tickets.