WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#11471 closed defect (bug) (fixed)

After bulk comment actions, spaces in a search are removed

Reported by: markjaquith Owned by: westi
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.8.4
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

search for "foo bar" or some other two word term in your comments.

Perform a bulk spam.

On redirect, the space between "foo" and "bar" will be missing.

Attachments (2)

11471.diff (1.9 KB) - added by nacin 6 years ago.
11471-simple.diff (763 bytes) - added by nacin 6 years ago.
Alternative: Just urlencode() it and move along.

Download all attachments as: .zip

Change History (6)

comment:1 @scribu6 years ago

Confirmed. Really strange.

@nacin6 years ago

comment:2 @nacin6 years ago

  • Keywords has-patch added

edit-comments.php handles redirection after a bulk action unlike the other pages. Instead of using wp_get_referer(), remove the query args it needs to, and adds the query args it needs to, it uses a base of "edit-comments.php" then adds on everything, including existing contextual query args such as the search query.

Patch follows the lead set by other pages. Alternatively, we can simply urlencode() $_REQUESTs? on what is currently line 106.

@nacin6 years ago

Alternative: Just urlencode() it and move along.

comment:3 @westi6 years ago

  • Milestone changed from 2.9 to 3.0
  • Owner set to westi
  • Status changed from new to accepted
  • Version changed from 2.9 to 2.8.4

This also exists in 2.8.

I would prefer to fix it the full way but this will have to wait for 3.0 as it is not a regression.

comment:4 @westi6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [12461]) Ensure that bulk comment actions do not remove spaces from search terms.
Also refactors comment bulk action redirect url building to be consistent with other operations.
Fixes #11471 props nacin.

Note: See TracTickets for help on using tickets.