WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 16 years ago

#11514 closed enhancement (fixed)

name and class in wp_list_categories not sanitized

Reported by: petervanderdoes Owned by: filosofo
Priority: normal Milestone: 3.1
Component: Taxonomy Version: 3.1
Severity: major Keywords: has-patch dev-feedback
Cc: Focuses:

Description

In wp_dropdown_categories the attributes name and class are sanitized but not in wp_list_categories.

Attachments (2)

sanitze.diff​ (407 bytes ) - added by petervanderdoes 17 years ago.
Adds sanitazition of name and class
clipboard.patch​ (513 bytes ) - added by hakre 16 years ago.
forgotten esc_attr

Download all attachments as: .zip

Change History (10)

@petervanderdoes
17 years ago

Adds sanitazition of name and class

#1 @hakre
17 years ago

  • Milestone Unassigned → 3.0
  • Priority low → normal
  • Severity normal → major

Considered hardening. Considered Blocker. Even 2.8 updates consider-able. Reference: [12539]

#2 @hakre
17 years ago

  • Keywords dev-feedback added

This is actually security related and some core-devs should at least consider to take a look in this ticket. Feedback wanted.

#3 @hakre
17 years ago

Related: #9875

#4 @nacin
17 years ago

  • Milestone 3.0
  • Resolution → invalid
  • Status new → closed

We don't use either of those attributes in wp_list_categories().

@hakre
16 years ago

forgotten esc_attr

#5 @hakre
16 years ago

  • Resolution invalid
  • Status closed → reopened
  • Version 2.9 → 3.1

Replying to nacin:

We don't use either of those attributes in wp_list_categories().

I see wp_list_categories() making use of $class in 3.1 trunk. Just attached the patch.

#6 @nacin
16 years ago

  • Milestone → 3.1

#8 @nacin
16 years ago

  • Resolution → fixed
  • Status reopened → closed

(In [16341]) Escape the class arg in wp_list_categories. props hakre, fixes #11514.

Note: See TracTickets for help on using tickets.