wp-config-sample.php inconsistency

[joshtime]

In wp-config-sample, there is a minor inconsistency.

// ** MySQL settings - You can get this info from your web host ** //
/** The name of the database for WordPress */
define('DB_NAME', 'putyourdbnamehere');

/** MySQL database username */
define('DB_USER', 'usernamehere');

/** MySQL database password */
define('DB_PASSWORD', 'yourpasswordhere');

DB_NAME says "put"
DB_USER says only "here"
DB_PASSWORD has "your". Password is not personal

Should be:

// ** MySQL settings - You can get this info from your web host ** //
/** The name of the database for WordPress */
define('DB_NAME', 'dbnamehere');

/** MySQL database username */
define('DB_USER', 'usernamehere');

/** MySQL database password */
define('DB_PASSWORD', 'passwordhere');

[joshtime]

Patch file

[joshtime]

The patch for setup-config.php

[joshtime]

Also added a patch for setup-config.php because setup-config.php searches the values to replace.

[miqrogroove]

see also [5001]

[hakre]

Consolidated patch (merged 2 prior patches into one)

[hakre]

Tested by running a new install from current trunk with patch applied. Worked.

[hakre]

Worth to commit or close as wontfix?

[miqrogroove]

IMO, wontfix. The inconsistency actually helps me see the difference between code-pattern and string literals.

[joshtime]

Replying to miqrogroove:

IMO, wontfix. The inconsistency actually helps me see the difference between code-pattern and string literals.

We actually could have the difference between code-pattern and string literals but a fix in the inconsistency would also be good. We actually could have:

/** The name of the database for WordPress */
define('DB_NAME', 'putdbnamehere');

/** MySQL database username */
define('DB_USER', 'putusernamehere');

/** MySQL database password */
define('DB_PASSWORD', 'putpasswordhere');

[dd32]

This gets a +1 from me, "Put Your Password Here" doesnt really specify what password, Whilst to a coder, being in the Database area givs us context, many users do not understand the way in which database connections work, and may expect the user password, rather than the mysql password.

Whitespace in the phrases would also be nice, "Database Name Here" for example.

[nacin]

(In [13837]) Standardize db config-sample values. fixes #11523

[nbachiyski]

The WordPress convention is to use dashes over underscores whenever we can. In this case we can.

Also, whenever you change placeholders, could you send a mail to wp-hackers/wp-polyglots -- there are people, who replace these with meaningful values, like we do in core.

[nacin]

I was actually going to go with spaces, but imo I found that to be counter-intuitive for two reasons -- one, you won't normally find spaces in these values, and two, double-clicking the value would then only select a single word. In many editors, dashes don't handle the latter any differently than spaces. Hence the underscores.

[nbachiyski]

Another place to be synced: ​http://core.trac.wordpress.org/browser/branches/iis/parameters.xml

[nacin]

Replying to nbachiyski:

Another place to be synced: ​http://core.trac.wordpress.org/browser/branches/iis/parameters.xml

We also need to add some salts there, possibly some other things.

[nacin]

(In [14542]) Update IIS parameters.xml to reflect new config-sample values. also add salts. see #11523.

[nacin]

Email dispatched to wp-hackers and wp-polyglots. I think we've changed everything we need to do here.