rev 12425 stream_set_timeout()

[solariz]

In the rev change 12425 / 12424 some handling for float timeouts was submitted. Some ppl. reporting for pingbacks not coming through on some systems. I noticed a discussion at the php.net comments about the stream_set_timeout function:

If you are using fsockopen() to create a connection, first going to write into the stream and then waiting for the reply (e.g. simulating HTTP request with some extra headers), then stream_set_timeout() must be set only after the write - if it is before write, it has no effect on the read timeout.

Maybe for a safety reason a null packet should be sent and stream_set_timeout added to avoid this as a problem source.

[miqrogroove]

Sending to 2.9.1 with high priority.

[miqrogroove]

On further reading, that particular comment was 3 years old and looks similar to ​http://bugs.php.net/bug.php?id=40750

There might have been a legacy conflict between fsockopen and the openssl library.

On the other hand, it would be a good idea to properly test the sockets transport before 2.9.1 goes out.

[hakre]

Related: #11468, [12424] for trunk, [12425] for 2.9

[dd32]

I believe this may've changed in later versions of PHP. From what i've read, stream_set_timeout() should generally be safe to be used in the way suggested here.

I'm not sure how PHP would handle sending a null packet either, or how that'd fit in with some web servers. I'm closing this as invalid, unless someone can point out a real-world bug caused by this, or can produce some odd results in testing.