WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#11580 closed defect (bug) (fixed)

recent posts widget isn't getting memcached

Reported by: Denis-de-Bernardy Owned by: ryan
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9
Component: Cache API Keywords: has-patch dev-feedback
Focuses: Cc:

Description (last modified by Denis-de-Bernardy)

the recent posts widget, and possibly a few others, uses wp_cache_add() instead of wp_cache_set(). when several widgets exist and are loaded, this results in the second one not getting cached.

Attachments (1)

11580.diff (2.1 KB) - added by Denis-de-Bernardy 5 years ago.

Download all attachments as: .zip

Change History (9)

@Denis-de-Bernardy5 years ago

comment:1 @Denis-de-Bernardy5 years ago

  • Keywords has-patch added

comment:2 @Denis-de-Bernardy5 years ago

  • Description modified (diff)

comment:3 @Denis-de-Bernardy5 years ago

the patch corrects the same issue with the wp_get_archives cache: when subsequent calls are done, they do not replace the cache stored in memcached, because the add() method gets used instead of the set() method.

comment:4 @scribu5 years ago

  • Milestone changed from 2.9.1 to 3.0

This is way out of scope for a maintenance release, IMO.

comment:5 @hakre5 years ago

  • Keywords dev-feedback added

suggesting early here.

comment:6 @Denis-de-Bernardy5 years ago

suggesting 2.9.1, myself. the only possible side effect is that memcached users get a faster site.

comment:7 @hakre5 years ago

Related: #10615

comment:8 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.