code improvements in wp_:dashboard_plugins_output()

[hakre]

Smaller code changes to improve the function. Stumbeled over this while digging into #11597 and #11518.

Tested against current trunk, Plugin listing works flawlessly.

Still ready to commit. Can a commiter please take care?

Does that do {} while(false); loop work? That will only ever run once from looking at the code.

Continue will just skip the rest of the loop and go straight to the conditional.

Best to leave it as a while(true) { break;} , Theres no need for the do syntax which is out of line with the rest of WordPress

Replying to dd32:

Does that do {} while(false); loop work? That will only ever run once from looking at the code.

Yes/Yes: Yes, it does work. Second yes is clear I guess. Let me know if not.

Best to leave it as a while(true) { break;} , Theres no need for the do syntax which is out of line with the rest of WordPress

Will adopt the patch accordingly to that feedback.

Next Iteration

• Changed the patch according to dd32 feedback regarding the do/while clause.

• Used in_array() to check for installed slugs instead of the reset/foreach combo[sic!] that is currently in there. Let me know if that's ok or not (that was with substr() compare but I assumed that this implicated problems as well).

• Description filter is put next to the other filters.

• Removed unnecessary isset() check after the while(true) loop.

• Added comments

• Formatted the code according to the styleguide

I have this running on my testbed against current trunk with no probs.

Refactoring tickets should have roper justification and clear rationale, performance benchmarks and unit tests, See: ​http://make.wordpress.org/core/2011/03/23/code-refactoring/

Due to the changes in 3.8 I was wanted close this ticket as wint fix. Looking at the code it it's confusing. It has obviously something to do with core refactoring but I think that function need to be looked at in 3.9. Specially since we simplified it now.

No movement in 5 years and none since 3.8 overhaul