Slash Missing in get_index_rel_link()

[miqrogroove]

... in link-template.php it looks like get_bloginfo('siteurl') should be user_trailingslashit(get_bloginfo('siteurl')) because my trailing slash is always missing grrrr.

[miqrogroove]

p.s. Filter is missing to. The full call should be user_trailingslashit(get_bloginfo('siteurl', 'display')) so that the link can get filtered.

[nacin]

get_bloginfo('siteurl') is actually deprecated -- this is its only use in core, apparently -- and user_trailingslashit conditionally slashes a URL depending on the permalink settings, so you're looking for trailingslashit.

I'm finding some other instances like this of 'display' not being triggered in core. Let's do another ticket for that.

[nacin]

Also hardens things a bit with esc_url.

[westi]

(In [12588]) Don't pass deprecated argument to get_bloginfo() in get_index_rel_link() also observer user trailing slash preferences. Fixes #11607 props nacin and miqrogroove.

[miqrogroove]

I confirmed what nacin said earlier, user_trailingslashit was not the correct wrapper for bloginfo('url'). trailingslashit seems to be the norm.

[westi]

Replying to miqrogroove:

I confirmed what nacin said earlier, user_trailingslashit was not the correct wrapper for bloginfo('url'). trailingslashit seems to be the norm.

I went with user_trailingslashit as I believe this fits with the intention of that function.

The other rel links that end up in the head also use it.

We could probably review all calls to trailingslashit and think about whether or not user_trailingslashit should be used but that is the subject of another ticket and is probably a rabbit hole we should not venture down.

[miqrogroove]

In particular, the /?p= links are using trailingslashit. I suspect the original intention was to do that only for root paths, but that isn't how it worked out.

[nacin]

The point of user_trailingslashit, as I understand it, is to distinguish between the option of www.example.com/2009/03/24/hello-world and www.example.com/2009/03/24/hello-world/.

I suppose that could also be translated to www.example.com and www.example.com/subdirectory/blog versus www.example.com/ and www.example.com/subdirectory/blog/.