Allow pluggable arg checking in current_theme_supports

[hakre]

There is an @todo task left in the file wp-includes/theme.php inside the current_theme_supports function. The original author should decide wether or not he wants to implement the noted feature or to just drop it.

From other code I've seen today, it's commong to check $args[0] for being an array and if so to set $args =& $arg[0];

[dd32]

attachment 11611.diff added

• My Take of how the pluggable support should be done.

[hakre]

Replying to dd32:

attachment 11611.diff added

• My Take of how the pluggable support should be done.

I've read it in another way then. Can you just share two or three words what your patch is doing / should provide? I have problems to understand it.

[hakre]

The @todo tag was introduced in [12350] by ryan based on it's own (untested marked) code in #11364. Maybe ryan should explain the @todo tag.

[dd32]

I've read it in another way then. Can you just share two or three words what your patch is doing / should provide? I have problems to understand it.

My understanding was, That for any features which accepts an array, There needed to be a filter to allow for plugins to take care of the array-based checking - As core only knows about how to handle the post-thumbnail array, Other features arrays may contain different data.

[nacin]

Patch looks okay to me.

There are other issues in the theme support API we're not going to get to in 3.0, such as a more robust remove_theme_support() (#12739) that can handle multiple arguments. Moving to 3.1 for now.

[jane]

Missed the boat, entering beta. 3.2-early.

[duck_]

Pretty much how I was writing the patch before I double checked for an existing ticket.

However, I think moving the return apply_filters out of the switch statement would be better for readability. Having it as the default case makes the final return true; dead code and weird.

[ryan]

Per duck_'s comment

[ryan]

Unit tests

[ryan]

In [19682]:

Allow pluggable arg checking in current_theme_supports. Props dd32. fixes #11611

[ryan]

​http://unit-tests.trac.wordpress.org/changeset/495