Stop using $id global

[scribu]

We already have the $post global which has the ID field.

So the $id global can be replaced with $post->ID everywhere.

[scribu]

Remove $id global from the_ID(), get_the_ID() and get_the_content()

[Denis-de-Bernardy]

that's a big change which might potentially break a lot of themes and plugins.

[scribu]

Such as?

[scribu]

Themes and plugins should be using get_the_ID() anyway.

[Denis-de-Bernardy]

Replying to scribu:

Such as?

Subscribe to comments comes to mind. Or at least it did in prior versions. I'm sure we'd find a few by looking.

[prettyboymp]

This shouldn't affect plugins that still use global $id since it will be still be set in setup_post_content(). Core functions will just stop using it. Its at least a small step in getting rid of all the globals.

[nacin]

This looks good.

[nacin]

I would commit this, but we use $id in a lot more places than post.php. It's not a bad idea to reduce our dependence on globals even by one, but we might as well do it across the board if we are to do it.

[xibe]

Should we create a ticket with the grand project of getting rid of all globals for 3.1?

[nacin]

Replying to xibe:

Should we create a ticket with the grand project of getting rid of all globals for 3.1?

Heh, yea, that's not going to happen so easily. :)

[xibe]

Replying to nacin:

Heh, yea, that's not going to happen so easily. :)

I guess so :)
But that would most certainly appease a lot of developers who like to snark at the "code is poetry" motto.

[nacin]

Moving out of 3.0 for now.

[prettyboymp]

related #10471

[scribu]

Replace all instances

[scribu]

Updated patch removes all instances of $id that I could find.

[scribu]

(In [15549]) Don't use the global anymore. Fixes #11624

[nacin]

(In [15563]) Adjustments to [15549]. See #11624.