WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11627 closed defect (bug) (fixed)

parts of metadata API fail on user metadata

Reported by: wnorris Owned by:
Milestone: 2.9.1 Priority: normal
Severity: major Version: 2.9
Component: General Keywords: has-patch
Focuses: Cc:

Description

two functions in the new metadata API reference the column named 'meta_id' directly, those are update_metadata and delete_metadata. In the usermeta table however, this column is actually named umeta_id. Using either of these two functions to update or delete user metadata results in a WordPress database error.

I think the best long term solution would be to rename this column to 'meta_id' so that it's consistent. However, I can imagine that would break a few plugins.

Attachments (2)

meta.diff (1.8 KB) - added by wnorris 4 years ago.
meta.no-function.diff (1.6 KB) - added by wnorris 4 years ago.

Download all attachments as: .zip

Change History (8)

wnorris4 years ago

comment:1 dd324 years ago

  • Keywords db metadata removed
  • Milestone changed from 3.0 to 2.9.1

comment:2 dd324 years ago

  • Keywords has-patch added; needs-patch removed

comment:3 nacin4 years ago

Looks good, though I think we should spare the unnecessary function and just do $id_column = 'user' == $meta_type ? 'umeta_id' : 'meta_id';.

wnorris4 years ago

comment:4 wnorris4 years ago

yeah, that's fine by me... I don't have strong feelings either way. Additional patch added that doesn't add the additional function.

comment:5 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12563]) Use umeta_id for user meta. Props wnorris. fixes #11627 for 2.9

comment:6 ryan4 years ago

[12562] for trunk.

Note: See TracTickets for help on using tickets.