WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#11637 closed enhancement (fixed)

Use new $required_php_version global

Reported by: nacin Owned by:
Milestone: 3.0 Priority: low
Severity: minor Version: 2.9
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description

We created $required_php_version, so we might as well use it where we can. Already done for $required_mysql_version in [12480].

We're moving down the PHP check in wp-settings.php, but I don't think that should be a problem. Other option is to move up the WPINC define.

Attachments (2)

11637-php_version.diff (4.4 KB) - added by nacin 5 years ago.
Forgot to mention in the ticket description that this patch also removes a check for at least 4.3 in wp-db.php.
11637.2.diff (2.3 KB) - added by nacin 4 years ago.
Updated against trunk r12933 (changes to wp-settings.php were handled in #11881)

Download all attachments as: .zip

Change History (4)

nacin5 years ago

Forgot to mention in the ticket description that this patch also removes a check for at least 4.3 in wp-db.php.

nacin4 years ago

Updated against trunk r12933 (changes to wp-settings.php were handled in #11881)

comment:1 nacin4 years ago

  • Keywords commit added
  • Version set to 2.9

Patch refreshed.

comment:2 westi4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[12939] - Use $required_php_version. Props nacin. fixes #11637

Note: See TracTickets for help on using tickets.