WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11638 closed defect (bug) (fixed)

update-core.php doesn't remove the upgrade files if the upgrade fails due to too old of a PHP or MySQL version

Reported by: nacin Owned by:
Milestone: 2.9.1 Priority: normal
Severity: normal Version: 2.9
Component: Upgrade/Install Keywords: has-patch tested
Focuses: Cc:

Description

Related: #11464, where this code came from.

wp-admin/includes/update-core.php, which gets copied over after download during an upgrade, has a new check in 2.9 to ensure that the MySQL and PHP versions are is required by the downloaded version.

However, I didn't account for the fact that the code should clean up after itself by deleting the downloaded package on failure, just as it does on any other failure it encounters. This should be fixed in 2.9.1.

Patch on its way.

Attachments (2)

11638.diff (895 bytes) - added by nacin 5 years ago.
11638.2.diff (1.0 KB) - added by nacin 5 years ago.
We also need to bump the local $wp_version to 2.9.1. See also #11639.

Download all attachments as: .zip

Change History (5)

nacin5 years ago

comment:1 nacin5 years ago

  • Keywords has-patch tested added

nacin5 years ago

We also need to bump the local $wp_version to 2.9.1. See also #11639.

comment:2 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12564]) Cleanup after bailing when php or mysql versions are not compat. Props nacin. fixes #11638 for trunk

comment:3 ryan5 years ago

(In [12565]) Cleanup after bailing when php or mysql versions are not compat. Props nacin. fixes #11638 for 2.9

Note: See TracTickets for help on using tickets.