WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 2 years ago

#11645 closed defect (bug) (duplicate)

Admin style, input fields and dark OS themes

Reported by: tonyf12 Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0.1
Component: Accessibility Keywords: has-patch close
Focuses: Cc:

Description

On the ACP, if you are using a dark OS theme (for example the HumanLogin theme included in Ubuntu), many of the form fields have an explicit background-color:#FFFFFF set. On most dark themes, the default font color is also white, so this causes the form fields to be displayed as white text on white background.

Possible fixes:
Remove the explicit background-color declaraton.
or
Add an explicit color:black declaration

Attachments (2)

11645.diff (1.6 KB) - added by andrewryno 3 years ago.
11645.2.diff (653 bytes) - added by andrewryno 3 years ago.

Download all attachments as: .zip

Change History (21)

comment:1 tonyf124 years ago

Trac stripped out some newlines I didn't expect. I hope it's still readable.

comment:2 hakre4 years ago

  • Component changed from General to Accessibility

Then we need to reset the foreground colors as well.

Related: #10881

comment:3 hakre4 years ago

  • Keywords needs-patch reporter-feedback added
  • Milestone changed from Unassigned to 3.0

Can you please make a screenshot and upload it?

comment:4 hakre4 years ago

Realted: #10985

comment:5 rfair4044 years ago

I tried to duplicate this issue on several OS's and browsers and all I found was that on certain high contrast settings this issue exists.

http://rfair.homelinux.com/files/2010/01/ACP-color-issus-muli-browsers.png

Ubuntu 9.10 64 bit high contrast, only firefox is effected, tested fine on ie and ff on windows 7

http://rfair.homelinux.com/blog/wp-admin-issues/acp-color-issues-ticket-11645/

comment:6 nacin4 years ago

  • Type changed from enhancement to defect (bug)

comment:7 nacin4 years ago

  • Milestone changed from 3.0 to Future Release

Future pending patch.

comment:8 tonyf124 years ago

  • Keywords reporter-feedback removed
  • Version changed from 2.9 to 3.0.1

A bit of further feedback:

Chrome is unaffected, as are most of the windows browsers. Firefox on Linux uses the OS controls however, so is affected. Also still exists as of 3.0.1

Screenshots:

http://anyhub.net/file/quickpress.png
http://anyhub.net/file/3title.png
http://anyhub.net/file/excerpt.png

comment:9 follow-up: tonyf124 years ago

  • Version changed from 3.0.1 to 2.9

Actually, just totally ignore that, I misread the issue I reported myself. Sorry, how do I delete comments?

comment:10 in reply to: ↑ 9 tonyf124 years ago

  • Version changed from 2.9 to 3.0.1

Replying to tonyf12:

Actually, just totally ignore that, I misread the issue I reported myself. Sorry, how do I delete comments?

*sigh* Ok, I'm really sorry, but turns out I was right with the files the first time.

comment:11 hakre3 years ago

  • Keywords dev-feedback added

Maybe something for UI?

comment:12 ocean903 years ago

  • Keywords ui-feedback added; dev-feedback removed

If UI, then use ui-feedback.

andrewryno3 years ago

comment:13 andrewryno3 years ago

Attached possible fix. I don't have Linux to test it with, so someone else may have to do that.

andrewryno3 years ago

comment:14 andrewryno3 years ago

Ignore the first one. Had some left over changes from another fix.

comment:15 hakre3 years ago

Thanks for looking into this and providing a patch. Patch looks good in my eyes.

comment:16 SergeyBiryukov3 years ago

  • Keywords has-patch added; needs-patch removed

comment:17 seolife3 years ago

Nothing.

Last edited 3 years ago by ocean90 (previous) (diff)

comment:18 helenyhou2 years ago

  • Keywords close added; ui-feedback removed

Duplicate: #19923, marked as commit for 3.4. Might want to close this one in favor of, but will let somebody else decide which is best.

comment:19 SergeyBiryukov2 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.