WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11652 closed enhancement (fixed)

Use _deprecated_argument() on get_bloginfo()

Reported by: nacin Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch
Focuses: Cc:

Description

_deprecated_argument() (#11386) is flexible enough to be used to mark deprecated values of function arguments, not just arguments themselves.

We should use it to mark get_bloginfo('siteurl') and get_bloginfo('home') as deprecated. Patch also changes any uses of those in core to 'url'.

This ticket and patch assumes that the final patch of #11386 is committed first, which simplifies _deprecated_argument() a bit and makes the function a bit more flexible.

(Also related, #10805, marking user levels as deprecated.)

Attachments (1)

11652.diff (5.5 KB) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (6)

nacin4 years ago

comment:1 nacin4 years ago

  • Type changed from defect (bug) to enhancement

comment:2 nacin4 years ago

Forgot to mention, patch does not update an instance of get_bloginfo('siteurl') that is addressed in #11607. That would need to be committed before or with this, otherwise we'll be triggering deprecated errors on every blog (unless a default filter is removed).

comment:3 westi4 years ago

Looks good.

Going to go with a simpler change in get_bloginfo as I think it is more readable and affects less of the code flow.

comment:4 westi4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12587]) Use _deprecated_argument() in get_bloginfo() and then don't pass deprecated argument to get_bloginfo(). Fixes #11652 props nacin.

comment:5 westi4 years ago

(In [12589]) Don't pass deprecated argument to get_bloginfo() in the classic theme. See #11652 props nacin.

Note: See TracTickets for help on using tickets.