WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#11655 closed enhancement (fixed)

TinyMCE wpeditimage plugin styling and cleanup

Reported by: Simek Owned by: azaozz
Milestone: 3.0 Priority: normal
Severity: minor Version: 2.9
Component: General Keywords: has-patch tested 2nd-opinion
Focuses: Cc:

Description

I've done some styling and cleanup of this plugin:

  • minified version of "editimage.js" added
  • some styling and cleanup
  • small cursor improvements in JS file according to CSS changes

This enhancement don't touch the essential files, so I've set Milestone to 2.9.1 but it definitely need second opinion.

My own ToDo (things that I can't correct/change only by myself | this list could be postponed to 3.0):

  • add ThickboxWindow Caption "Edit an Image" and rename basic tab to "Simple Edit"
  • set style for currently selected zoom value in scale - now if we move cursor we don't know which scale were selected before

Attachments (1)

weeditimage.styling.and.cleanup.patch (52.4 KB) - added by Simek 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 westi4 years ago

  • Milestone changed from 2.9.1 to 3.0
  • Owner set to azaozz
  • Status changed from new to reviewing

Enhancements / code refactoring or tidy ups should go into a major release milestone.

Assigning to Andrew to review as he is the TinyMCE expert.

comment:2 azaozz4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [12660]) Clean CSS of the Edit Image popup in the visual editor props Simek, show changed image size and fill width or height when left blank, fixes #11655, fixes #10442

Note: See TracTickets for help on using tickets.