WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#1166 closed defect (bug) (fixed)

Pingbacks don't work with allow_url_fopen=Off

Reported by: anonymousbugger Owned by: matt
Milestone: Priority: normal
Severity: major Version: 1.5
Component: XML-RPC Keywords:
Focuses: Cc:

Description

pingback_ping() uses @fopen($pagelinkedfrom, 'r') to check if the source URI exists. This check always fails if allow_url_fopen is Off (recommended setting), that means pingbacks don't work.

Please consider replacing this fopen call with something like the code from http://7sheaven.pingouin.ca/forum/showthread.php?t=13

Attachments (1)

foo.php (162 bytes) - added by anonymousbugger 10 years ago.

Download all attachments as: .zip

Change History (11)

comment:2 @anonymousbugger10 years ago

  • Patch set to No

comment:3 @matt10 years ago

  • Owner changed from anonymous to matt
  • Resolution changed from 10 to 50
  • Status changed from new to closed

I can't use the code from the link if the link doesn't work.

comment:4 @anonymousbugger10 years ago

  • Resolution changed from 50 to 30
  • Status changed from closed to assigned

Just use snoopy instead of fopen($url)

comment:5 @MC_incubus10 years ago

Agreed. We're bundling Snoopy with WordPress, and using it will increase compat.

comment:6 @matt10 years ago

So remote fwrites work even if remote fopen is off?

comment:7 @matt10 years ago

Dreamhost, which recently disabled remote fopen, is suggesting users use curl. Curl is only used in Snoopy for SSL connections.

We may also want to upgrade snoopy.

comment:8 @anonymousbugger10 years ago

I think the CURL PHP module is the way to go.

The module is available on a lot of hosts, the 'curl' binary isn't (especially in chroot environments). So if you continue to use Snoopy, it should be modified to use the module instead of the binary.

comment:9 @matt10 years ago

Possible fix checked in, please confirm

comment:10 @matt10 years ago

  • fixed_in_version set to 1.5.1
  • Resolution changed from 30 to 20
  • Status changed from assigned to closed

Resolving pending further feedback

@anonymousbugger10 years ago

Note: See TracTickets for help on using tickets.