WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11666 closed defect (bug) (fixed)

upgrade.php dies hard on MySQL < 4.1.0

Reported by: miqrogroove Owned by:
Milestone: 2.9.1 Priority: normal
Severity: blocker Version: 2.9
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

Need to revert some of [12409]

MySQL 4.1.0 is required to execute SET NAMES, and as a result WP 2.9 upgrader never loads on old servers. This leaves webmasters unaware of the version incompatibility.

Attachments (1)

11666-upgrade-failure.patch (435 bytes) - added by miqrogroove 5 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 @miqrogroove5 years ago

  • Keywords has-patch added

comment:2 @Denis-de-Bernardy5 years ago

mm, it shouldn't even go so far that it actually lets the webmaster think he's fine. the upgrader should bail without upgrading the DB if the php and mysql versions are not met.

comment:3 @miqrogroove5 years ago

Agreed. My patch enables mysql version checking. Without it, the webmaster will only get a blank screen or internal server error.

comment:4 @ryan5 years ago

(In [12573]) Don't set charset if mysql version does not have the collation cap. Props miqrogroove. see #11666 for trunk

comment:5 @ryan5 years ago

(In [12574]) Don't set charset if mysql version does not have the collation cap. Props miqrogroove. see #11666 for 2.9k

comment:6 @ryan5 years ago

(In [12575]) Check PHP and MySQL versions in upgrade.php. see #11666

comment:7 @ryan5 years ago

(In [12576]) Check PHP and MySQL versions in upgrade.php. see #11666 for 2.9

comment:8 @ryan5 years ago

Added some quick checks to upgrade.php.

comment:9 @automattor5 years ago

(In [12578]) Check PHP and MySQL versions in install.php. see #11666 for 2.9

comment:10 @ryan5 years ago

[12577] for trunk.

comment:11 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

comment:12 @ryan5 years ago

Good enough for now.

comment:13 @hakre5 years ago

  • Keywords has-patch removed

Another way to signal changes is to offer the changelog to the user: #11739

Note: See TracTickets for help on using tickets.