Restore AYS for posts, pages, comments when trash is disabled
|Reported by:||nacin||Owned by:|
Related -- for media attachments, see #11673.
When someone decides to disable trash, they are presented with no AYS dialog on delete. This is a regression from pre-2.9 functionality.
Yes, the whole point of trash was to rid the UI of AYS dialogs. I don't like AYS dialogs either and find trash+undo a great enhancement. But if a user doesn't want to use trash, or if a site admin doesn't want their users to use trash, then they should still be given an AYS to prevent accidental clicks and unsure deletes.
We provided admins with a way to disable trash if they so choose, which should restore them pre-2.9 functionality, but it doesn't.
We still have AYS in tags and categories, which makes this inconsistent across the UI. In #11673 we should be restoring it to media.
Starting this off at 2.9.1 as it is a regression (if the user doesn't want to use a feature that we gave them the ability to disable). With trash enabled by default, I don't have much of a problem if it is moved to 3.0 though.