WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#11679 closed enhancement (fixed)

Mark 2nd param of load_plugin_textdomain() as deprecated

Reported by: sirzooro Owned by: nacin
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

Mark 2nd param of load_plugin_textdomain() as deprecated.

Attachments (1)

11679.diff (570 bytes) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 nacin4 years ago

  • Owner set to nacin
  • Status changed from new to accepted

nacin4 years ago

comment:2 nacin4 years ago

  • Keywords has-patch commit added; needs-patch removed

We normally check for empty() but since the function is very particular about checking for $abs_rel_path !== false, I patched it on !== false.

Commit candidate.

comment:3 westi4 years ago

I would prefer to put the check inside where the argument is used.

That way we only warn people who just use this argument rather than those who supply both so as to enable the plugin to function with old WordPress version.

comment:4 westi4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [12594]) Mark 2nd param of load_plugin_textdomain() as deprecated. Fixes #11679 props nacin.

Note: See TracTickets for help on using tickets.