update_metadata() passes only the first meta_id

[scribu]

Code to reproduce:

function update_metadata_action_test($meta_id) {
	var_dump($meta_id);
}
add_action('update_post_meta', 'update_metadata_action_test');

add_metadata('post', 1, 'mykey', 'value1');
add_metadata('post', 1, 'mykey', 'value2');

update_metadata('post', 1, 'mykey', 'new value');

Expected result:

Array ( [0] => 101 [1] => 102 )

Actual result:

string(3) "101"

[scribu]

Two solutions:

1. update_usermeta() only updates the first value that it finds

2. update_usermeta() uses $wpdb->get_col() instead of $wpdb->get_var()

The first would create more severe backward compatibility issues than the second.

[scribu]

Related: #10905

[scribu]

Come to think of it, I have no ideea why $meta_id is passed at all (and as the first parameter at that). It's not accesible from anywhere else in the API.

[nacin]

Needs to be handled with #10905 I'd think.

[wonderboymusic]

Added patch to get all meta_ids and call actions on all meta_ids individually, rather than breaking current behavior by passing arrays.

[nacin]

I've never really noticed that update_metadata() can update more than one row at a time.

[wonderboymusic]

Patch refreshed against trunk like whoa - passes all Unit Tests

[boonebgorges]

11683.2.diff​ refreshes for latest trunk, and adds some Delightful unit tests.

[boonebgorges]

In 30140:

Pass all updated meta IDs to filters in update_metadata().

Props wonderboymusic.
Fixes #11683.

[DrewAPicture]

The hook docs always need to directly precede the hook line so the parser can match them up.

[boonebgorges]

You learn something new every day :) Thanks, DrewAPicture.

[DrewAPicture]

In 30149:

Relocate hook docs so they directly precede the hook lines moved into foreach statements in [30140].

It's necessary for hook docs to directly precede hook lines so the parser can correctly match them up. This change relocates hook docs for update_{$meta_type}_meta, update_postmeta, updated_{$meta_type}_meta, and updated_postmeta.

Fixes #11683.

[DrewAPicture]

Replying to boonebgorges:

You learn something new every day :) Thanks, DrewAPicture.

Absolutely :-)

In the case of hooks, it's particularly important because phpDocumentor doesn't actually support parsing hook docs out of the box. Our implementation calls for the docs to directly precede hook lines so they don't get confused with function-level DocBlocks.