WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 months ago

#11697 assigned defect (bug)

Keep private posts in the admin area / Was: Make private posts a canonical plugin — at Version 12

Reported by: Denis-de-Bernardy Owned by: ericmann
Milestone: Future Release Priority: normal
Severity: normal Version: 2.9
Component: Posts, Post Types Keywords: has-patch needs-testing featured
Focuses: Cc:

Description (last modified by Denis-de-Bernardy)

Said Matt:

Also, a lot of the complexity of private posts could be avoided by a relatively simple change: saying they're only viewable in the dashboard. (Which I think is close to how people use them already.)


There are quite a few tickets related to private posts that can be viewed by users who should, and even more tickets related to private comments that can be viewed by users who aren't authorized to view the post.

There also is at least one ticket that highlights a performance issue related to private posts.

http://core.trac.wordpress.org/search?q=private

Would it be an option to turn this into a canonical plugin and begone with the problems?

Change History (13)

comment:1 Denis-de-Bernardy4 years ago

A few tickets for reference:#11695, #11375, #9499, #9347, #9211, #9144, #9136, #9125... the list (and the confusion) goes on, and on...

comment:2 follow-up: ericmann4 years ago

Considering the majority of users (at least the majority of users I have contact with) don't even use the private post functionality, I see the logic in moving it to a canonical plug-in. However, that doesn't address any of the underlying visibility or performance issues.

comment:3 miqrogroove4 years ago

+1 Even though I have to set Private if I want to make a test post without publishing it, the reality is I never do that kind of testing on a production website.

comment:4 in reply to: ↑ 2 Denis-de-Bernardy4 years ago

Replying to ericmann:

However, that doesn't address any of the underlying visibility or performance issues.

True, but that would be the canonical plugin's team worry, rather than our own.

comment:5 Denis-de-Bernardy4 years ago

  • Keywords needs-patch added; 2nd-opinion removed

see #11375 in particular on the performance problem (I closed it as dup of this)

comment:6 follow-up: ericmann4 years ago

  • Owner set to ericmann
  • Status changed from new to accepted

In the interest of moving all of the private posts functionality to a canonical plugin, would someone mind pointing me in the direction of existing code? I can probably find most of it on my own ... but a head start would be nice.

comment:7 ericmann4 years ago

  • Cc eric@… added

comment:8 in reply to: ↑ 6 Denis-de-Bernardy4 years ago

Replying to ericmann:

In the interest of moving all of the private posts functionality to a canonical plugin, would someone mind pointing me in the direction of existing code? I can probably find most of it on my own ... but a head start would be nice.

Searching the code base for 'private' and "private" gives a good starting point. Basically, it leads you to:

  • admin ajax
  • the post and page editors (including a js file)
  • meta boxes api
  • admin templates (lists and inline edit)
  • comments api (e.g. posting on private posts)
  • capabilities
  • xmlrpc
  • importers

I think that the importers can safely be left untouched.

The rest would basically need to be replaced with appropriate filters. Make sure this gets blessed by a core dev before you start, however.

comment:9 matt4 years ago

I think this is worth discussing, but I feel like we should prove core plugins work with post-by-email and a few other pilots before re-examining other functionality.

Also while I doubt almost anyone on Trac will appreciate private posts, a lot of people use them extensively.

comment:10 follow-ups: matt4 years ago

Also, a lot of the complexity of private posts could be avoided by a relatively simple change: saying they're only viewable in the dashboard. (Which I think is close to how people use them already.)

comment:11 in reply to: ↑ 10 Denis-de-Bernardy4 years ago

Replying to matt:

Also, a lot of the complexity of private posts could be avoided by a relatively simple change: saying they're only viewable in the dashboard. (Which I think is close to how people use them already.)

I'd mega +zillions that particular idea.

Denis-de-Bernardy4 years ago

keep private posts in the admin area, per Matt's suggestion

comment:12 in reply to: ↑ 10 Denis-de-Bernardy4 years ago

  • Description modified (diff)
  • Keywords has-patch needs-testing added; needs-patch removed
  • Summary changed from Make private posts a canonical plugin to Keep private posts in the admin area / Was: Make private posts a canonical plugin

Replying to matt:

Also, a lot of the complexity of private posts could be avoided by a relatively simple change: saying they're only viewable in the dashboard. (Which I think is close to how people use them already.)

I've attached a patch (untested) that aims to do just that, in case anyone wants to test it.

Note: See TracTickets for help on using tickets.