Tag cloud widget - font size

[tin68]

Hi

Not really a bug - but more a question.

The tag cloud widget displays the tags with different font sizes - this works correctly on my blog.

But I don't understand and I think it doesn't make sense to set the font-size with a decimal number:

eg. of HTML code

style='font-size: 9.3582089552239pt;'

An integer value of 8 to 22 should be correct in my opinion.

[nacin]

A little rounding wouldn't be a bad idea, but a float is valid here. wp_tag_cloud() can accept a smallest value, largest value, and a unit. Browsers do use or even rely on floats for some units, take em for example.

[tin68]

But tag cloud is using not "em" but "pt".

Open Source project are great ;-) I made now a little patch to category-template.php file, line 684 is changed now to:

   ( round( $smallest + ( ( $count - $min_count ) * $font_step ) ) )

[nacin]

The tag cloud widget uses wp_tag_cloud() with default args (with the 'widget_tag_cloud_args' filter applied). But wp_generate_tag_cloud() can accept a unit.

While I perhaps see the case for rounding, round() creates an integer unless you include a precision argument.

Honestly, I'm not sure it is necessary. Maybe with a precision of at least 4.

[tin68]

Sorry, which browser can display the difference of font-size 9.4545 and 9.4546 ? No - precision of 4 is useless. Perhaps precision 1 makes sense - then to browser an round it up or down.

[nacin]

9.4545 might be displayed differently than 9.4546 due to screen resolutions and how the pixels fall.

That's not the point I was trying to make though. The point is that we can't round it to 0 or 1, as the unit may rely heavily on decimals, such as em.

[nacin]

Related #14577

[helen]

Given:

The point is that we can't round it to 0 or 1, as the unit may rely heavily on decimals, such as em.

Closing.