deprecate generate_random_password()

[Denis-de-Bernardy]

WP has a wp_generate_password() function, which we should use instead.

[Denis-de-Bernardy]

atm, it's used in ms-edit.php and ms-functions,php

[ryan]

Untested

[ryan]

(In [12624]) Deprecate generate_random_password(). fixes #11746

[nacin]

There's a spelling mistake in the third argument of the _deprecated_functon call.

[nacin]

Some inline docs added as well.

[nacin]

Little better inline documentation

[westi]

Docs look good.
I'm wondering why we are preserving the exact functionality of this function can't we just use the function we recommend in this function like we do for other deprecated functions.

[westi]

(In [12635]) phpDoc for ms-deprecated.php props nacin.
Make generate_random_password use wp_generate_password()
Fixes #11746.

[uglyrobot]

I know the function is pluggable, but can we keep the random_password filter? We use it.

[uglyrobot]

Add filter

[Denis-de-Bernardy]

+1

[Denis-de-Bernardy]

r12653