make install_blog_defaults() use the stuff in the normal WP installer

[Denis-de-Bernardy]

there seems to be a lot of redundant code in there. for the sake of not maintaining it twice, we should re-engineer this so it uses the normal WP installer

[ryan]

(In [12776]) Deprecate wp_install_blog_defaults(). Use wp_install_defaults() instead. fixes #11747 see #11644

[jamescollins]

In [12776], I noticed that line 245 of wp-admin/includes/upgrade.php contains:

$wpdb->update( $wpdb->options, array('option_value' => $user->user_email), array('option_name' => 'admin_email') );

Is there any reason why

update_option('admin_email', $user->user_email);

isn't used instead?

I realise that the $wpdb->update() call comes from old WPMU code, but it'd be good to update it because it might cause problems for people using an object cache.

[ryan]

Using straight queries instead of higher-level API is typical of the upgrade and install code. It is done to avoid polluting cache, triggering actions, and exercising parts of the API that rely on database updates that might not have taken place yet.

[jamescollins]

Replying to ryan:

Using straight queries instead of higher-level API is typical of the upgrade and install code. It is done to avoid polluting cache, triggering actions, and exercising parts of the API that rely on database updates that might not have taken place yet.

Thanks for the clarification Ryan. That makes sense.