WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#11762 closed enhancement (fixed)

inconsistent function name conventions in newly introduced files

Reported by: Denis-de-Bernardy Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: needs-patch
Focuses: Cc:

Description

newly introduced MS files have at least one function, whose name (wpmu_checkAvailableSpace) is inconsistent with the typical conventions used in WP.

For the sake of improving the code's quality, we should rename/deprecate them accordingly.

Change History (6)

comment:1 filosofo5 years ago

Perhaps related, we need to decide how to handle everything with "wpmu" in it (a lot of stuff: filters, functions, variables, etc.). Deprecate? Continue to use?

comment:2 wpmuguru4 years ago

  • Keywords needs-patch added

For that one we could get rid of that function entirely and put the code directly in media_upload_form() (rboren's suggestion) or rename the function.

There are also duplicate functions in the multisite code that perform similar but not exactly the same as the wp_ ones. Example: wpmu_create_user, wp_create_user. We would look at a patch to deprecate those as well.

comment:3 ryan4 years ago

(In [12824]) Add wp-admin/includes/ms-deprecated.php. Deprecate wpmu_checkAvailableSpace. Introduce is_upload_space_available(). see #11762

comment:4 ryan4 years ago

We should give priority to eliminating functions that duplicate core WP API and fixing CamelCase intrusions. wpmu_* cleanup that doesn't meet those two criteria should be lower priority.

comment:5 ryan4 years ago

(In [12824]) Add wp-admin/includes/ms-deprecated.php. Deprecate wpmu_checkAvailableSpace. Introduce is_upload_space_available(). see #11762

comment:6 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Looks like the camelcase ones are all gone now. Closing this ticket. We'll deal with wpmu_ functions over time.

Note: See TracTickets for help on using tickets.