inconsistent function name conventions in newly introduced files

[Denis-de-Bernardy]

newly introduced MS files have at least one function, whose name (wpmu_checkAvailableSpace) is inconsistent with the typical conventions used in WP.

For the sake of improving the code's quality, we should rename/deprecate them accordingly.

[filosofo]

Perhaps related, we need to decide how to handle everything with "wpmu" in it (a lot of stuff: filters, functions, variables, etc.). Deprecate? Continue to use?

[wpmuguru]

For that one we could get rid of that function entirely and put the code directly in media_upload_form() (rboren's suggestion) or rename the function.

There are also duplicate functions in the multisite code that perform similar but not exactly the same as the wp_ ones. Example: wpmu_create_user, wp_create_user. We would look at a patch to deprecate those as well.

[ryan]

(In [12824]) Add wp-admin/includes/ms-deprecated.php. Deprecate wpmu_checkAvailableSpace. Introduce is_upload_space_available(). see #11762

[ryan]

We should give priority to eliminating functions that duplicate core WP API and fixing CamelCase intrusions. wpmu_* cleanup that doesn't meet those two criteria should be lower priority.

[ryan]

(In [12824]) Add wp-admin/includes/ms-deprecated.php. Deprecate wpmu_checkAvailableSpace. Introduce is_upload_space_available(). see #11762

[ryan]

Looks like the camelcase ones are all gone now. Closing this ticket. We'll deal with wpmu_ functions over time.