move secret_salt_warning() over into the global WP functionality

[Denis-de-Bernardy]

secret_salt_warning() adds a warning that prompts users to add a couple of defines to their site so as to reenforce its security. We should turn this on by default, rather than just for multisite installations.

[nacin]

Related (keys and their defaults): #12081.

Thinking that for non-MS this might be better as part of the health check plugin.

[nacin]

#12159 should ensure new installs are at least secure. We're also addressing salts in Tools > Network.

secret_salt_warning() is missing NONCE_SALT. I don't think we should add it until we can fix #12142 simultaneously.

[wpmuguru]

(In [13768]) add NONCE_SALT to secret_salt_warning(), see #11764

[wpmuguru]

Replying to nacin:

Related (keys and their defaults): #12081.

Thinking that for non-MS this might be better as part of the health check plugin.

I agree. An end user implementing the SALTS/KEYS may have login issues (possibly all users) as is documented in #12142.

I'm closing. If someone strenuously objects they can re-open.

[nacin]

I agree.

Something tells me that #12142 is exacerbated by a bug somewhere in MS, as changing, adding or removing keys and salts in single-install WP doesn't seem to cause problems, beyond a logout.