WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#11773 closed defect (bug) (invalid)

weird looking logic in ms-edit.php vs ms-functions.php

Reported by: Denis-de-Bernardy Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: dev-feedback
Focuses: Cc:

Description

In ms-edit.php, you can only update the site admin's email if it's a valid email:

		if( is_email( $_POST['admin_email'] ) )
			update_site_option( "admin_email", $_POST['admin_email'] );

But in ms-functions.php, there is a check in newblog_notify_siteadmin(), that goes:

	$email = get_site_option( 'admin_email' );
	if( is_email($email) == false )
		return false;

which seems to indicate that a MU install can live without a site admin email. so, question... is it possible, or not?

Change History (2)

comment:1 wpmuguru4 years ago

The MU installer was not added to trunk but did require a valid email address.

The first check is to ensure that when the MU site options were saved that the email provided for the site admin (now super admin) was valid.

The admin_email address record can be edited or removed directly from the database. The second check is to ensure that what was retrieved from the site options was a valid email address.

comment:2 nacin4 years ago

  • Milestone 3.0 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Seems invalid then.

Note: See TracTickets for help on using tickets.