Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#11788 closed enhancement (fixed)

barely sanitized strings are put straight in the database in ms-site.php

Reported by: Denis-de-Bernardy Owned by:
Priority: normal Milestone: 3.0
Component: Multisite Version: 3.0
Severity: major Keywords:
Cc: Focuses:

Description

there arguably are magic quotes, but it's freaky scary to read things such as:

$s = wp_specialchars( trim( $_GET[ 's' ] ) );
...
" AND ( {$wpdb->blogs}.domain LIKE '%{$s}%' OR {$wpdb->blogs}.path LIKE '%{$s}%' ) ";

Change History (2)

#1 @ninjaWR
17 years ago

  • Milestone Future Release3.0
  • Severity normalmajor

Should be fixed before 3.0 ships, IMO

#2 @nacin
17 years ago

  • Resolutionfixed
  • Status newclosed

#11644. Both fixed at some point.

Note: See TracTickets for help on using tickets.