Can't delete alternate text from image in media library

[doug]

Steps to reproduce:

1. Upload an image to the media library and fill in the "Alternate text" field. Save the data.

2. In the media library, click to edit the image.

3. Delete all text in the Alternate text field and click Update Media.

4. In the media library, click to edit the image again and notice that the alt text has NOT been deleted.

(The same thing happens using the pop-up style media editor from within the post editor.)

Work-around: delete all text in the Alternate text field, then type a space in the field. When updating, the alt text (including the space) will be removed.

[scribu]

Confirmed in 3.0-alpha.

[miqrogroove]

Confirmed in 2.9.1.

[reaperhulk]

This appears to be caused by the media_upload_form_handler testing for both isset() and !empty() on the image_alt. If you remove the !empty() it behaves as expected.

Potential issue with fix: If there are any pages that use media_upload_form_handler and pass an empty string (rather than excluding image_alt entirely when they don't want to touch it) this could cause a problem.

[miqrogroove]

[12055]

[miqrogroove]

+1 works as described, and makes sense to me.

[miqrogroove]

Refreshed patch file by reaperhulk

[dd32]

(In [13283]) Allow Deletion of Media Alt text. Props reaperhulk. Fixes #11805