Improve SQL query used by get_terms()

[sirzooro]

#11076 / [12658] changes get_terms() so it uses SQL query with multiple conditions in WHERE clause - one for each included / excluded term. It will be better to change generated SQL from:

AND (t.term_id = 1 OR t.term_id = 2 OR ...)
AND (t.term_id <> 1 AND t.term_id <> 2 AND ...)

to:

AND t.term_id IN (1, 2, ...)
AND t.term_id NOT IN (1, 2, ...)

[sirzooro]

OK, looks that I have to provide a patch for this :)

[dd32]

instead of those ugly loops, something similar to this might be possible?

$interms = array_map('intval', $interms);
$inclusions = ' AND t.term_id IN ( ' . implode(',', $interms) . ' )';

(note, Untested, and havnt looked at the code closer than the patch)

[sirzooro]

no loops this time

[wonderboymusic]

Refreshed, we should be using IN and NOT IN in most of these old functions that accept arrays of IDs

[duck_]

11823.2.diff​ fixes a bug in the exclude_tree handling (the current patch will only exclude the last tree in the array).

[wonderboymusic]

.3.diff adds unit tests

[wonderboymusic]

In 25162:

Improve the include / exclude SQL generation in get_terms() by using IN and NOT IN where applicable. Adds unit tests for include / exclude.

Props sirzooro, duck_.

Fixes #11823.

[wonderboymusic]

In 25169:

No need to re-map the return values of wp_parse_id_list() to int.

See #22074, #11823.

[kovshenin]

[25162] causes a database error if an include or exclude argument is not empty, but is also not really a term id. 11823.4.diff​ addresses that.

For reference, here's a sample SQL query it generates (note that 0):

SELECT t.*, tt.* FROM wptests_terms AS t INNER JOIN wptests_term_taxonomy AS tt ON t.term_id = tt.term_id WHERE tt.taxonomy IN ('post_tag')0 ORDER BY t.name ASC

[wonderboymusic]

In 25257:

Avoid database error when include or exclude is not really a term_id. Adds more unit tests.

Props kovshenin.
Fixes #11823.