WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#11836 closed defect (bug) (fixed)

Clean up register_sidebar(s) functions

Reported by: scribu Owned by: azaozz
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Widgets Keywords: has-patch needs-refresh reporter-feedback
Focuses: Cc:

Description

Some minor code improvements to the two widget-related functions.

Attachments (1)

register_sidebar.diff (893 bytes) - added by scribu 5 years ago.

Download all attachments as: .zip

Change History (3)

@scribu5 years ago

comment:1 @nacin5 years ago

  • Keywords needs-refresh reporter-feedback added; commit removed

I've looked at this a few times and can't help but notice that you removed $_args['id'] = $args['id']; as if it was $args['id'] = $args['id'];. I imagine that's a mistake?

Also, patch is now stale -- looks like that code has changed.

Second hunk looks okay though.

comment:2 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14154]) Use wp_parse_args in register_sidebar. fixes #11836, props scribu.

Note: See TracTickets for help on using tickets.