define('WP_DEBUG', false) generates a silent E_NOTICE

[nacin]

In wp-settings.php, we're checking if WP_DEBUG is defined and is true. If its not, then we're defining WP_DEBUG as false.

Of course, if WP_DEBUG is defined as false already, then we're generating a silent E_NOTICE (suppressed by the error_reporting initially set in wp-load.php).

Code should check if WP_DEBUG is defined before defining to false.

[nacin]

Realized this would be a better way to do it

[hakre]

Just reviewed the ticket & two patches. +1 for the second approach, think it's worth to fix and ok for commit.

[westi]

(In [12685]) Tidy up logic for defining WP_DEBUG so we only define it if it isn't already. Fixes #11837 props nacin.