Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#11849 closed defect (bug) (duplicate)

admin-ajax does notices

Reported by: hakre Owned by: westi
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Warnings/Notices Keywords: has-patch
Focuses: Cc:


Minor Problem. Attached patch just shows where.

Attachments (1)

11849.patch (659 bytes) - added by hakre 6 years ago.

Download all attachments as: .zip

Change History (4)

6 years ago

#1 @hakre
6 years ago

  • Summary changed from admin-ajax has does notices to admin-ajax does notices

#2 @nacin
6 years ago

Lower down in the file when we check for $_POST, we surround a switch with an isset.

Here when we check for $_GET (with the patch), if not set it would allow an "wp_ajax_" action to execute.

Also, when we check for $_REQUEST['action'] for nopriv, we check if it is empty.

We should probably standardize all of them to prevent an empty action from triggering a hook.

#3 @nacin
6 years ago

  • Milestone 3.0 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Was handled elsewhere in 3.0.

Note: See TracTickets for help on using tickets.