WordPress.org

Make WordPress Core

Changes between Initial Version and Version 24 of Ticket #11881


Ignore:
Timestamp:
01/15/10 21:52:59 (6 years ago)
Author:
wpmuguru
Comment:

Replying to nacin:

I have questions about two variables losing global scope and whether we need to globalize them:

  • $mu_plugins, an array of PHP files from the must use plugins folder. We unset the corresponding array holding plain WP plugins to include. It is used nowhere in core and I highly doubt it needs to remain a global.
  • $prefix, as in $prefix = $wpdb->set_prefix($table_prefix); -- which is then checked for is_wp_error().

I think the answer to both is no (just being cautious), in which case 11881.5.diff is good on my end.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11881

    • Property Keywords has-patch added
  • Ticket #11881 – Description

    initial v24  
    1 setup-config.php step 2 is broken now that wp-db.php calls is_multisite(). In addition it also causes a notice. 
    2  
    3 {{{ 
    4 Notice: Use of undefined constant WP_DEBUG - assumed 'WP_DEBUG' in /var/www/trunk/wp-includes/wp-db.php on line 370 
    5  
    6 Fatal error: Call to undefined function is_multisite() in /var/www/trunk/wp-includes/wp-db.php on line 373 
    7 }}} 
    8  
    9 Because setup-config.php uses wp-db.php without first including wp-settings.php which is where WP_DEBUG and is_multisite are defined it causes a notice and a fatal error. 
     111881.5.diff tested ok with my installs.