Conditional tag for terms

[pavelevap]

Conditional tag for terms would be very helpfull. There is is_tax() for taxonomies but from WordPress 2.9 it does not work for terms in taxonomies. So any function is_tax_term() would be fine (see ​http://core.trac.wordpress.org/ticket/10721).

[filosofo]

Attached patch adds conditional is_tax_term([taxonomy], [term]).

Tested with custom taxonomies, categories, and post tags.

[scribu]

I don't think $term should be optional.

[filosofo]

Replying to scribu:

I don't think $term should be optional.

Why not? It's parallel to is_category, for which the specific category is optional.

function is_category($category = '') {
   return is_tax_term('category', $category);
}

[scribu]

How about we add $term as an optional parameter to is_tax(), directly?

It seems more intuitive.

[nacin]

I was actually going to suggest we add an optional parameter $taxonomy to is_term()... but, well:

function is_term($term, $taxonomy = '', $parent = 0)

Why isn't that sufficient?

[filosofo]

Replying to scribu:

How about we add $term as an optional parameter to is_tax(), directly?

It seems more intuitive.

I'm good with that. Second patch does that.

[nacin]

function is_term($term, $taxonomy = '', $parent = 0)

Clearly misread the ticket here :(

I'm +1 on the second patch.

[scribu]

Second patch seems to be working as expected.

[scribu]

better taxonomy validation

[scribu]

is_tax.11904.2.diff validates the taxonomy array upfront, to prevent a very unlikely edge case.

Also reduced the nesting level a bit.

[dd32]

(In [13486]) More powerful version is is_tax(). Props filosofo, scribu. Adds $term parameter. Fixes #11904

[dd32]

I removed most of the nesting and seperated it into 2 branches.

re-open if anyone can see a mistake in the conversion.

[dd32]

(In [13495]) Revert part of r13486, is_tax() is false for tags

categories. See #11904

[dd32]

Re-opening, I've reverted part of this, allowing is_tax() return true for Tags and Categories has side effects where core expects is_Tax() to be false for those taxonomies.

Whilst i agree that Tags and categories should return true, More work needs to be done to make it compatible with the rest of core.

[scribu]

I think the original goal of this ticket has been reached.

We should open a new monster ticket named "Treat categories and tags like regular taxonomies" :)