WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11908 closed defect (bug) (fixed)

erroneous check in theme updates

Reported by: Denis-de-Bernardy Owned by: dd32
Milestone: 3.0 Priority: normal
Severity: critical Version: 2.9.1
Component: Upgrade/Install Keywords: has-patch tested
Focuses: Cc:

Description

Theme updates expects an array, but WP checks for an object. this inconsistent behavior can break the possibility to update a theme.

patch attached.

Attachments (1)

11908.diff (1.1 KB) - added by Denis-de-Bernardy 4 years ago.

Download all attachments as: .zip

Change History (9)

Denis-de-Bernardy4 years ago

comment:1 dd324 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12743]) Correct the Theme update package check. Props Denis-de-Bernardy. Fixes #11908 for trunk

comment:2 dd324 years ago

  • Milestone changed from 2.9.2 to 3.0

bumping to 3.0 only.

You can treat arrays and objects interchangably in my testing, and this doesnt appear to be breaking any functionality in 2.9. Feel free to reopen if you disagree.

comment:3 Denis-de-Bernardy4 years ago

It breaks updates on some servers, actually. Namely the one from #11811.

Leaving this closed, but it would be sweet to have it in 2.9.2.

comment:4 nacin4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5 nacin4 years ago

  • Milestone changed from 3.0 to 2.9.3

Per forum threads and a wp-testers thread, looks like fixing this in a maintenance release is a good idea.

http://lists.automattic.com/pipermail/wp-testers/2010-February/012110.html

comment:6 ryan4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [13173]) Correct the Theme update package check. Props Denis-de-Bernardy. Fixes #11908 for 2.9

comment:7 nacin4 years ago

  • Milestone 2.9.3 deleted

Milestone 2.9.3 deleted

comment:8 nacin4 years ago

  • Milestone set to 3.0
Note: See TracTickets for help on using tickets.