WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#11937 closed defect (bug) (fixed)

ID clash in 'Link Categories/Post Tags' Page

Reported by: Utkarsh Owned by: dd32
Milestone: 3.0 Priority: low
Severity: minor Version: 2.9
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

There are 2 elements each with the ID 'name', 'slug' and 'description' in wp-admin/edit-link-categories.php For this reason, the <label> for these items in the Add Link Category part do not point to the respective input boxes.

Attachments (2)

11937.3.patch (3.0 KB) - added by ShaneF 4 years ago.
11937.4.diff (4.8 KB) - added by ShaneF 4 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Utkarsh4 years ago

  • Cc admin@… added

comment:2 scribu4 years ago

  • Component changed from General to Administration
  • Priority changed from normal to low
  • Severity changed from normal to minor

comment:3 ShaneF4 years ago

  • Keywords has-patch commit added; need-patch removed
  • Owner set to ShaneF
  • Status changed from new to accepted

ShaneF4 years ago

comment:4 ShaneF4 years ago

Leaving this at Milestone 3.0. Right now I don't want to change any compatibility with 2.9.x series.

comment:5 ryan4 years ago

wp_insert_term() expects description and slug. I don't see any mapping from link_description and link_slug back to description and slug.

comment:6 follow-up: dd324 years ago

  • Keywords needs-patch added; has-patch commit removed

The Edit tags page suffers from this same issue i think.

Its the Table column headers which are conflicting i think, Probably best to give them the id of 'column-$column' instead of modifying the form?

comment:7 ShaneF4 years ago

Ok. :-) Working on it.

ShaneF4 years ago

comment:8 ShaneF4 years ago

  • Cc ShaneF added
  • Keywords has-patch commit added; needs-patch removed
  • Summary changed from ID clash in Link Categories Page to ID clash in 'Link Categories/Post Tags' Page

comment:9 in reply to: ↑ 6 ShaneF4 years ago

Replying to dd32:

The Edit tags page suffers from this same issue i think.

Its the Table column headers which are conflicting i think, Probably best to give them the id of 'column-$column' instead of modifying the form?

I looked into this before. All the javascript code would have to be changed to reflect that and it's more than just these two pages that use the same javascript.

comment:10 nacin4 years ago

  • Keywords commit removed
  • Owner changed from ShaneF to dd32
  • Status changed from accepted to assigned

comment:11 dd324 years ago

Is there a need to change the Fields Names? Its the ID's which are conflicting.

I'm not 100%, But from what i can see, its only the field Labels which are using the ID's.

I'm going to commit a change to the ID's, if people can test and report if they notice anything odd, that'd be appreciated.

comment:12 dd324 years ago

(In [13852]) Change form field ID's to prevent ID clashes with listing table column headers. See #11937

comment:13 dd324 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

the HTML Validator doesnt mention any issues on the affected pages, and functionality seems to be working still.

Closing as fixed, Re-open if this has caused a bug.

Note: See TracTickets for help on using tickets.