WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#11940 closed defect (bug) (invalid)

Eclipse validation false-positive: Error: Duplicate tag (html)

Reported by: UnderWordPressure Owned by:
Milestone: Priority: low
Severity: trivial Version: 2.9.1
Component: Optimization Keywords: has-patch
Focuses: Cc:

Description

I develop my add-ons in PHP-Eclipse.
On every new WP-Release there was a validation error in

wp-includes/functions.php

Reason is a Here-Document at line 2863 (see screenshots).
If this block will be printed, the code is okay for the Eclipse validation.

Attachments (3)

duplicate-html-tag.jpg (130.8 KB) - added by UnderWordPressure 8 years ago.
11940.patch (1017 bytes) - added by UnderWordPressure 8 years ago.
duplicate-html-tag-compare.jpg (174.6 KB) - added by UnderWordPressure 8 years ago.

Download all attachments as: .zip

Change History (7)

#1 @hakre
8 years ago

  • Component changed from Validation to Optimization
  • Keywords has-patch added
  • Milestone changed from Unassigned to Future Release

The HTML validator in Eclipse is not all the time able to properly work with HTML fragments within PHP code, that is why it shows a error/warning here and there.

To show the picutre on current trunk:

Description	Resource	Path	Location	Type
Duplicate tag (html).	functions.php	/wordpress-trunk merger/wp-includes	line 2897	HTML Problem
Attribute name (onClick) uses wrong case character.	media.php	/wordpress-trunk merger/wp-admin/includes	line 1457	HTML Problem
Attribute name (onClick) uses wrong case character.	media.php	/wordpress-trunk merger/wp-admin/includes	line 1468	HTML Problem
Attribute name (onMouseDown) uses wrong case character.	media.php	/wordpress-trunk merger/wp-admin/includes	line 1789	HTML Problem
Attribute name (onMouseDown) uses wrong case character.	media.php	/wordpress-trunk merger/wp-admin/includes	line 1790	HTML Problem
Duplicate tag (html).	functions.php	/wordpress-trunk merger/wp-includes	line 2898	HTML Problem
Duplicate tag (html).	wp-login.php	/wordpress-trunk merger	line 466	HTML Problem
Duplicate tag (html).	wp-login.php	/wordpress-trunk merger	line 512	HTML Problem
Duplicate tag (html).	wp-login.php	/wordpress-trunk merger	line 603	HTML Problem
End tag (</link>) not needed.	export.php	/wordpress-trunk merger/wp-admin/includes	line 280	HTML Problem
End tag (</link>) not needed.	export.php	/wordpress-trunk merger/wp-admin/includes	line 318	HTML Problem
End tag (</link>) not needed.	feed-rdf.php	/wordpress-trunk merger/wp-includes	line 23	HTML Problem
End tag (</link>) not needed.	feed-rdf.php	/wordpress-trunk merger/wp-includes	line 42	HTML Problem
End tag (</link>) not needed.	feed-rss.php	/wordpress-trunk merger/wp-includes	line 16	HTML Problem
End tag (</link>) not needed.	feed-rss.php	/wordpress-trunk merger/wp-includes	line 27	HTML Problem
End tag (</link>) not needed.	feed-rss2-comments.php	/wordpress-trunk merger/wp-includes	line 29	HTML Problem
End tag (</link>) not needed.	feed-rss2-comments.php	/wordpress-trunk merger/wp-includes	line 51	HTML Problem
End tag (</link>) not needed.	feed-rss2.php	/wordpress-trunk merger/wp-includes	line 26	HTML Problem
End tag (</link>) not needed.	feed-rss2.php	/wordpress-trunk merger/wp-includes	line 37	HTML Problem
Invalid character used in text string (
		<<?php echo $tag ?> <?php comment_class(empty( $args['has_children'] ) ? '' : 'parent') ?> id="comment-<?php comment_ID() ?>">
		).	comment-template.php	/wordpress-trunk merger/wp-includes	line 1272	HTML Problem
Invalid character used in text string (';
			}
		}
		}
		for (i = 0; i < my_src.length; i++) {
			img = new Image();
			img.src = my_src[i];
			img_attr = 'id="img' + i + '"';
			skip = false;

			maybeappend = ').	press-this.php	/wordpress-trunk merger/wp-admin	line 246	HTML Problem
Invalid character used in text string (';

			if (img.width && img.height) {
				if (img.width >= 30 && img.height >= 30) {
					aspect = img.width / img.height;
					scale = (aspect > 1) ? (71 / img.width) : (71 / img.height);

					w = img.width;
					h = img.height;

					if (scale < 1) {
						w = parseInt(img.width * scale);
						h = parseInt(img.height * scale);
					}
					img_attr += ' style="width: ' + w + 'px; height: ' + h + 'px;"';
					strtoappend += maybeappend;
				}
			} else {
				strtoappend += maybeappend;
			}
		}

		function pick(img, desc) {
			if (img) {
				if('object' == typeof jQuery('.photolist input') && jQuery('.photolist input').length != 0) length = jQuery('.photolist input').length;
				if(length == 0) length = 1;
				jQuery('.photolist').append(').	press-this.php	/wordpress-trunk merger/wp-admin	line 254	HTML Problem
Invalid character used in text string (",
					cache : false,
					async : false,
		   			data: "ajax=photo_images&u=).	press-this.php	/wordpress-trunk merger/wp-admin	line 237	HTML Problem
Invalid character used in text string (",
				cache : false,
				async : false,
		   		data: "ajax=photo_images&u=).	press-this.php	/wordpress-trunk merger/wp-admin	line 226	HTML Problem
Invalid location of tag (#cdata-section).	feed-atom.php	/wordpress-trunk merger/wp-includes	line 38	HTML Problem
Invalid location of tag (a).	ms-options.php	/wordpress-trunk merger/wp-admin	line 280	HTML Problem
Invalid location of tag (a).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2761	HTML Problem
Invalid location of tag (a).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2765	HTML Problem
Invalid location of tag (a).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2770	HTML Problem
Invalid location of tag (a).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2774	HTML Problem
Invalid location of tag (body).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 43	HTML Problem
Invalid location of tag (body).	footer.php	/wordpress-trunk merger/wp-content/themes/classic	line 17	HTML Problem
Invalid location of tag (body).	footer.php	/wordpress-trunk merger/wp-content/themes/default	line 25	HTML Problem
Invalid location of tag (body).	wp-login.php	/wordpress-trunk merger	line 465	HTML Problem
Invalid location of tag (body).	wp-login.php	/wordpress-trunk merger	line 512	HTML Problem
Invalid location of tag (body).	wp-login.php	/wordpress-trunk merger	line 602	HTML Problem
Invalid location of tag (div).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 14	HTML Problem
Invalid location of tag (div).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 14	HTML Problem
Invalid location of tag (div).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 15	HTML Problem
Invalid location of tag (div).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 15	HTML Problem
Invalid location of tag (div).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 16	HTML Problem
Invalid location of tag (div).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 16	HTML Problem
Invalid location of tag (div).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 17	HTML Problem
Invalid location of tag (div).	admin-footer.php	/wordpress-trunk merger/wp-admin	line 19	HTML Problem
Invalid location of tag (div).	akismet.php	/wordpress-trunk merger/wp-content/plugins/akismet	line 1120	HTML Problem
Invalid location of tag (div).	akismet.php	/wordpress-trunk merger/wp-content/plugins/akismet	line 1120	HTML Problem
Invalid location of tag (div).	footer.php	/wordpress-trunk merger/wp-content/themes/classic	line 8	HTML Problem
Invalid location of tag (div).	footer.php	/wordpress-trunk merger/wp-content/themes/classic	line 14	HTML Problem
Invalid location of tag (div).	footer.php	/wordpress-trunk merger/wp-content/themes/default	line 9	HTML Problem
Invalid location of tag (div).	footer.php	/wordpress-trunk merger/wp-content/themes/default	line 19	HTML Problem
Invalid location of tag (div).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1352	HTML Problem
Invalid location of tag (div).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1389	HTML Problem
Invalid location of tag (div).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1394	HTML Problem
Invalid location of tag (div).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1451	HTML Problem
Invalid location of tag (div).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1464	HTML Problem
Invalid location of tag (div).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1685	HTML Problem
Invalid location of tag (div).	press-this.php	/wordpress-trunk merger/wp-admin	line 520	HTML Problem
Invalid location of tag (div).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2160	HTML Problem
Invalid location of tag (div).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2390	HTML Problem
Invalid location of tag (div).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2393	HTML Problem
Invalid location of tag (div).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2872	HTML Problem
Invalid location of tag (div).	template.php	/wordpress-trunk merger/wp-admin/includes	line 3235	HTML Problem
Invalid location of tag (div).	template.php	/wordpress-trunk merger/wp-admin/includes	line 3540	HTML Problem
Invalid location of tag (div).	template.php	/wordpress-trunk merger/wp-admin/includes	line 3752	HTML Problem
Invalid location of tag (div).	wp-login.php	/wordpress-trunk merger	line 458	HTML Problem
Invalid location of tag (div).	wp-login.php	/wordpress-trunk merger	line 512	HTML Problem
Invalid location of tag (div).	wp-login.php	/wordpress-trunk merger	line 588	HTML Problem
Invalid location of tag (div).	wp-signup.php	/wordpress-trunk merger	line 95	HTML Problem
Invalid location of tag (form).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1498	HTML Problem
Invalid location of tag (form).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1558	HTML Problem
Invalid location of tag (form).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1696	HTML Problem
Invalid location of tag (form).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1826	HTML Problem
Invalid location of tag (form).	media.php	/wordpress-trunk merger/wp-admin/includes	line 1930	HTML Problem
Invalid location of tag (form).	template.php	/wordpress-trunk merger/wp-admin/includes	line 222	HTML Problem
Invalid location of tag (form).	template.php	/wordpress-trunk merger/wp-admin/includes	line 1018	HTML Problem
Invalid location of tag (form).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2326	HTML Problem
Invalid location of tag (form).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2750	HTML Problem
Invalid location of tag (form).	template.php	/wordpress-trunk merger/wp-admin/includes	line 2876	HTML Problem
Invalid location of tag (form).	wp-login.php	/wordpress-trunk merger	line 438	HTML Problem
Invalid location of tag (form).	wp-login.php	/wordpress-trunk merger	line 552	HTML Problem
Invalid location of tag (hr).	footer.php	/wordpress-trunk merger/wp-content/themes/default	line 8	HTML Problem
Invalid location of tag (html).	press-this.php	/wordpress-trunk merger/wp-admin	line 302	HTML Problem
Invalid location of tag (html).	press-this.php	/wordpress-trunk merger/wp-admin	line 303	HTML Problem
Invalid location of tag (label).	options-discussion.php	/wordpress-trunk merger/wp-admin	line 63	HTML Problem
Invalid location of tag (label).	options-discussion.php	/wordpress-trunk merger/wp-admin	line 80	HTML Problem
Invalid location of tag (label).	options-discussion.php	/wordpress-trunk merger/wp-admin	line 94	HTML Problem
Invalid location of tag (legend).	users.php	/wordpress-trunk merger/wp-admin	line 178	HTML Problem
Invalid location of tag (li).	template.php	/wordpress-trunk merger/wp-admin/includes	line 565	HTML Problem
Invalid location of tag (li).	theme-install.php	/wordpress-trunk merger/wp-admin/includes	line 208	HTML Problem
Invalid location of tag (noscript).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 231	HTML Problem
Invalid location of tag (p).	akismet.php	/wordpress-trunk merger/wp-content/plugins/akismet	line 826	HTML Problem
Invalid location of tag (p).	akismet.php	/wordpress-trunk merger/wp-content/plugins/akismet	line 830	HTML Problem
Invalid location of tag (p).	footer.php	/wordpress-trunk merger/wp-content/themes/classic	line 12	HTML Problem
Invalid location of tag (p).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 194	HTML Problem
Invalid location of tag (p).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 195	HTML Problem
Invalid location of tag (p).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 211	HTML Problem
Invalid location of tag (p).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 212	HTML Problem
Invalid location of tag (p).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 213	HTML Problem
Invalid location of tag (p).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 223	HTML Problem
Invalid location of tag (p).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 225	HTML Problem
Invalid location of tag (p).	livejournal.php	/wordpress-trunk merger/wp-admin/import	line 229	HTML Problem

Normally there is not taken any care of such things because we do not write code to fix against Eclipse deficiencies.

Please only put tickets to component validation that are about output validation.

I suggest to close as invalid.

If you do not want to see such errors any longer, please disbale the HTML checker for the files it does report those warnings in error (e.g. by creating a working set for validation in your eclipse configuration).

#2 @hakre
8 years ago

  • Summary changed from Eclipse validation error:Duplicate tag (html) to Eclipse validation false-positive: Error: Duplicate tag (html)

#3 @UnderWordPressure
8 years ago

Ok, there is no problem for me.
I want just give you an information about that.
Ticket can close "as is".
regards

#4 @westi
8 years ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

Eclipse works really badly here when some tags are echo'd and some output and I don't think we will likely make changes here just to make eclipse happy

Closing as invalid.

Note: See TracTickets for help on using tickets.