WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11981 closed defect (bug) (fixed)

Bad default data for icon_dir filter in in post-template.php

Reported by: chrisjean Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Media Keywords: has-patch
Focuses: Cc:

Description

Apparently an old batch of code was never updated in the get_attachment_icon_src function found in wp-includes/post-template.php. The default value for the icon_dir filter is get_template_directory()/images rather than ABSPATH.WPINC/images/crystal. This causes the returned icon path for mime type icons to not match the paired URL if the default directory is used.

The included patch has a fix that makes this filter's default value match the default value found in media.php and post.php.

The patch was generated off of 3.0-alpha.

Attachments (1)

post-template-icon_dir-fix.diff (570 bytes) - added by chrisbliss18 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 ryan4 years ago

Related: #6751

comment:2 nacin4 years ago

  • Milestone changed from Unassigned to Future Release

Marking as future to go along with #6751.

comment:3 hakre4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Patch is stale. Trunk is somehow fixed. The only bad default describben here I could find is located in get_attachment_icon_src(), depreceted since 2.5 or so.

I close as fixed. If the problem still exists, please feel free to reopen and provide a fresh patch. I could not find this issue any longer.

comment:4 nacin4 years ago

  • Milestone changed from Future Release to 3.1

This was fixed recently to introduce SSL support, I think.

Note: See TracTickets for help on using tickets.