WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12050 closed defect (bug) (fixed)

Link Manager Custom Column

Reported by: camiloclc Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.9.1
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

When adding custom columns to links, in wp-admin/link-manager.php line 242, the "td" attributes are not being echoed for these custom columns like it is in other row based pages (post, page, comment) on the switch statement, even though the variable is being populated.
The code in wp-admin/link-manager.php line 242 is:

<td><?php do_action('manage_link_custom_column', $column_name, $link->link_id); ?></td>

But it should be:

<td <?php echo $attributes ?>><?php do_action('manage_link_custom_column', $column_name, $link->link_id); ?></td>

Attachments (1)

12050.diff (490 bytes) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (3)

nacin4 years ago

comment:1 nacin4 years ago

  • Component changed from General to Administration
  • Keywords has-patch commit added; link link manager link custom removed
  • Milestone changed from Unassigned to 3.0

For what it's worth, I checked all other *_custom_column actions and this was the only one missing the attributes. (Not counting actions in ms-sites.php and ms-users.php that don't have attributes at all.)

comment:2 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12872]) Show td attributes for custon coolumns. Props camiloclc. fixes #12050

Note: See TracTickets for help on using tickets.