WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12066 closed defect (bug) (fixed)

Typo in canonical.php causes E_NOTICE, hinders query vars

Reported by: nacin Owned by: markjaquith
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Canonical Keywords: has-patch
Focuses: Cc:

Description

Typo in canonical.php, patch attached.

A simple ?author=1 would generate an E_NOTICE which then prevents headers from being sent.

This does affect functionality but it's more rare. Under a typical permalink setup, /?author=1&blah=2 should redirect to /author/admin/?blah=2. Instead, blah=2 is left off since when it comes time to check $redirect['query'] there's nothing to append.

Attachments (1)

12066.diff (654 bytes) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (2)

nacin4 years ago

comment:1 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12889]) User correct var. Props nacin. fixes #12066

Note: See TracTickets for help on using tickets.