Warning : in_array Invalid argument in wp-includes/post.php on line 1997

[firebird75]

Hello,

I am receiving a warning while publishing a new post through the post by email feature.

The warning states that the second argument is invalid in wp-includes/post.php on line 1997.

Here is the code :

if ( $post_name_check

in_array($slug, $wp_rewrite->feeds) ) {

If I modify this line to this :

if ( $post_name_check

in_array($slug, $feeds) ) {

Then the warning goes away. I am not sure however about the implications around this change.

Please note that you may not see this error by using the post by email feature as I am reusing the code as part of the plugin to allow custom post types submission by email but the code is the same, it is just the way I call it that is different. Instead of requiring the direct call to wp-mail.php, I have created a function which contains the code of wp-mail.php as part of my plugin.

The plugin in question is WATS (wordpress advanced ticket system).

The problem can be reproduced with any kind of email received (plain text, html, etc...).

[nacin]

Looking through the rest of the code the change looks correct without any implications. Above that:

$feeds = $wp_rewrite->feeds;
if ( !is_array($feeds) )
    $feeds = array();

And a bunch of $post_name_check || in_array($slug, $feeds) between that line and this as well.

Patch forthcoming.

[nacin]

Includes code convention cleanups. Actual fix is ~L 2267

[firebird75]

Damn, so fast, thanks a lot!

[westi]

This patch looks good.

[nacin]

(In [13075]) Use correct var name. Props firebird75. Whitespace cleanup in wp_unique_post_slug(). Fixes #12078.